[Portaudio] CMake updates and MinGW updates

[Nick Appleton]

Hi all,

I have a merge request from over a year ago which hasn’t yet been completed. I’ve made a couple of modifications to the top-level CMakeLists.txt recently to support including portaudio as a CMake package when installed on a system. I’d like to get it merged soon. Could someone please take a look at the changes and make some comments? Most of the non-CMake work was done by Rainer over a year ago to get portaudio building properly on MinGW with CMake.

https://app.assembla.com/spaces/portaudio/git/merge_requests/4858113

Nick

[Roland Winklmeier]

Am Do., 4. Okt. 2018 um 12:52 Uhr schrieb Nick Appleton <

Post by Nick Appleton
Hi all,
I have a merge request from over a year ago which hasn’t yet been
completed. I’ve made a couple of modifications to the top-level
CMakeLists.txt recently to support including portaudio as a CMake package
when installed on a system. I’d like to get it merged soon. Could someone
please take a look at the changes and make some comments? Most of the
non-CMake work was done by Rainer over a year ago to get portaudio building
properly on MinGW with CMake

Hi Nick,

good to see that this finally moves forward. I'm not sure if this comments
fits into the reivew or is a new thing, but just in case:
I recently realized that DirectX SDK was deprecated and integrated into
Windows SDK. I'm not sure from which version on wards, but the two SDK
versions (WinSDK 8.1 and WinSDK 10) both have DirectX headers and libraries
integrated. So MSVC just builds as fine as MinGW without the need of extra
DirectX SDK. Would it be possible to reflect that in the CMake build? Maybe
by a quick compile test whether DirectSound header and library are
available and if not fall back to find DirectX SDK?

Cheers Roland

[Nick Appleton]

Post by Nick Appleton
Hi all,
I have a merge request from over a year ago which hasn’t yet been completed. I’ve made a couple of modifications to the top-level CMakeLists.txt recently to support including portaudio as a CMake package when installed on a system. I’d like to get it merged soon. Could someone please take a look at the changes and make some comments? Most of the non-CMake work was done by Rainer over a year ago to get portaudio building properly on MinGW with CMake
Hi Nick,
I recently realized that DirectX SDK was deprecated and integrated into Windows SDK. I'm not sure from which version on wards, but the two SDK versions (WinSDK 8.1 and WinSDK 10) both have DirectX headers and libraries integrated. So MSVC just builds as fine as MinGW without the need of extra DirectX SDK. Would it be possible to reflect that in the CMake build? Maybe by a quick compile test whether DirectSound header and library are available and if not fall back to find DirectX SDK?
Cheers Roland

Hi Roland,

I do very little development on Windows, never use the DirectSound hostapi in my applications and never use MinGW when developing on Windows. I’m really happy to take patches and help others get fixes into the CMake support, but since the testing I’m going to do locally is minimal, I’d feel much better about taking something that someone else has tested more extensively.

I think I offered (I can’t even remember) to help Rainer get his patches in because:
* He had also done some work to the CMake support and I’m keen to get this working well for all users.
* I have an assembla account and Rainer did not.

What you’ve mentioned makes sense and if you propose some patches, I will certainly merge them into the request!

Thanks!

Nick